compare ranges by firstindex before by values (like vectors)#60565
compare ranges by firstindex before by values (like vectors)#60565adienes wants to merge 1 commit intoJuliaLang:masterfrom
firstindex before by values (like vectors)#60565Conversation
firstindex before by values (like vectors)firstindex before by values (like vectors)
|
the old behavior is explicitly tested for, but I think those tests are incorrect, right? |
|
This seems to have some overlap with #30950, although it's much smaller in scope. I fear this will be complicated and might be breaking. The axis of an axis is often ignored -- incorrectly -- but that behavior is ancient. |
|
note the following consequence: ancient or not, shouldn't we fix it? |
|
Please go ahead by all means, I'm not vetoing this. I'll just be interested in a PkgEval run to see if this impacts the ecosystem. |
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed1 packages crashed only on the current version.
242 packages crashed on the previous version too. ✖ Packages that failed121 packages failed only on the current version.
1994 packages failed on the previous version too. ✔ Packages that passed tests6 packages passed tests only on the current version.
4026 packages passed tests on the previous version too. ~ Packages that at least loaded5 packages successfully loaded only on the current version.
4010 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether4 packages were skipped only on the current version.
897 packages were skipped on the previous version too. |
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary✖ Packages that failed61 packages failed only on the current version.
52 packages failed on the previous version too. ✔ Packages that passed tests4 packages passed tests on the previous version too. |
particularly important after #59500 so that ranges match vectors!